Add aws crossplane private gatewayclass#172
Merged
Michael Vittrup Larsen (michaelvl) merged 1 commit intomainfrom May 22, 2023
Merged
Add aws crossplane private gatewayclass#172Michael Vittrup Larsen (michaelvl) merged 1 commit intomainfrom
Michael Vittrup Larsen (michaelvl) merged 1 commit intomainfrom
Conversation
Michael Vittrup Larsen (michaelvl)
requested a review
from Martin Villumsen (mvillumsen)
as a code owner
Sebastian Kalita (kuketro)
approved these changes
May 22, 2023
Contributor
Sebastian Kalita (kuketro)
left a comment
Sebastian Kalita (kuketro)
left a comment
There was a problem hiding this comment.
LGTM 👍
Michael Vittrup Larsen (michaelvl)
deleted the
feature/aws-crossplane-private-gatewayclass
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds another named
GatewayClassusing the AWS/Crossplane blueprint. The new 'private'GatewayClassis intended to be different from the 'public' class by having different atached policy defaults. This is however outside the scope of this PR.