Support multiple resources per template, aka. loops and conditions#174
Merged
Michael Vittrup Larsen (michaelvl) merged 9 commits intomainfrom May 25, 2023
Conversation
Michael Vittrup Larsen (michaelvl)
force-pushed
the
feature/155-loops-and-multiple-resources-in-templates
branch
2 times, most recently
from
f7ff180 to
7567b12
Compare
Michael Vittrup Larsen (michaelvl)
requested review from
Sebastian Kalita (kuketro) and
Martin Villumsen (mvillumsen)
as code owners
Michael Vittrup Larsen (michaelvl)
force-pushed
the
feature/155-loops-and-multiple-resources-in-templates
branch
from
6c8bf2a to
4354a2f
Compare
Michael Vittrup Larsen (michaelvl)
force-pushed
the
feature/155-loops-and-multiple-resources-in-templates
branch
from
4354a2f to
e0c492f
Compare
Merged
Michael Vittrup Larsen (michaelvl)
changed the title
Martin Villumsen (mvillumsen)
previously approved these changes
May 25, 2023
Contributor
Martin Villumsen (mvillumsen)
left a comment
Martin Villumsen (mvillumsen)
left a comment
There was a problem hiding this comment.
LGTM
Co-authored-by: Martin Villumsen <mvil@tv2.dk>
Michael Vittrup Larsen (michaelvl)
deleted the
feature/155-loops-and-multiple-resources-in-templates
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable support for templates with conditionals and loops. Currently a template must render to exactly one resource. This PR changes this, such that templates may render to zero, one or more resources which is an enabled for using e.g.
ifandrangein templates.The tests in
controllers/gateway_controller_test.goillustrates well this new feature.Fixes #155
Checklist