Add HorizontalPodAutoscaler and PodDisruptionBudget resources to aws-crossplane blueprint#186
Merged
Michael Vittrup Larsen (michaelvl) merged 8 commits intomainfrom Jun 9, 2023
Merged
Conversation
Michael Vittrup Larsen (michaelvl)
force-pushed
the
feature/hpa-for-istio
branch
from
7500c3f to
a52a7a5
Compare
…crossplane blueprint
Michael Vittrup Larsen (michaelvl)
force-pushed
the
feature/hpa-for-istio
branch
from
a52a7a5 to
15cf1c7
Compare
Michael Vittrup Larsen (michaelvl)
requested review from
Sebastian Kalita (kuketro) and
Martin Villumsen (mvillumsen)
as code owners
Contributor
Martin Villumsen (mvillumsen)
left a comment
Martin Villumsen (mvillumsen)
left a comment
There was a problem hiding this comment.
My comments also apply to blueprints/contour-istio/gatewayclassblueprint-contour-istio-cert.yaml and blueprints/contour-istio/gatewayclassblueprint-contour-istio.yaml
blueprints/aws-alb-crossplane/gatewayclassblueprint-aws-alb-crossplane.yaml
Outdated
Show resolved
Hide resolved
blueprints/aws-alb-crossplane/gatewayclassblueprint-aws-alb-crossplane.yaml
Show resolved
Hide resolved
blueprints/aws-alb-crossplane/gatewayclassblueprint-aws-alb-crossplane.yaml
Show resolved
Hide resolved
Martin Villumsen (mvillumsen)
approved these changes
Jun 9, 2023
blueprints/aws-alb-crossplane/gatewayclassblueprint-aws-alb-crossplane.yaml
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds configurable
HorizontalPodAutoscalerandPodDisruptionBudgetresources to the aws/crossplane/istio blueprint.This PR require the features from istio/istio#45192
It has been tested succesfully with the Istio change from the above PR.
Fixes #152
Checklist