Skip to content

Added podAnnotations feature #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Michael Vittrup Larsen (michaelvl) merged 4 commits into from
May 31, 2023
Merged

Added podAnnotations feature #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6516432
Added podAnnotations feature
May 31, 2023
12213cf
Update CHANGELOG
May 31, 2023
84674af
Update README
May 31, 2023
8dd341e
Update chart testing to skip version increment test
michaelvl May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/configs/ct-lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ chart-dirs:
- charts
helm-extra-args: --timeout 600s
validate-maintainers: false
check-version-increment: false
1 change: 1 addition & 0 deletions charts/bifrost-gateway-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## [UNRELEASED]

- Example text, add your PR info according to example below below this line. Do not bump chart version in Chart.yaml.
- Added podAnnotations to chart, allowing users to set annotations for the controller pod

## [0.1.6]

Expand Down
1 change: 1 addition & 0 deletions charts/bifrost-gateway-controller/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ Gateway API driven management of network infrastructure across Kubernetes and cl
| controllerManager.manager.resources.limits.memory | string | `"128Mi"` | |
| controllerManager.manager.resources.requests.cpu | string | `"10m"` | |
| controllerManager.manager.resources.requests.memory | string | `"64Mi"` | |
| controllerManager.podAnnotations | object | `{}` | |
| controllerManager.replicas | int | `1` | |
| metricsService.ports[0].name | string | `"http"` | |
| metricsService.ports[0].port | int | `8080` | |
Expand Down
4 changes: 3 additions & 1 deletion charts/bifrost-gateway-controller/ci/with-additional-annotations-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
controllerManager:
annotations:
tv2.dk/gateway-controller/annontations: true
tv2.dk/gateway-controller/annotations: true
podAnnotations:
tv2.dk/gateway-controller/podAnnotations: true
3 changes: 3 additions & 0 deletions charts/bifrost-gateway-controller/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ spec:
control-plane: manager
{{- include "gateway-controller.selectorLabels" . | nindent 8 }}
annotations:
{{- with .Values.controllerManager.podAnnotations }}
{{- toYaml . | nindent 8 }}
{{- end }}
kubectl.kubernetes.io/default-container: manager
spec:
containers:
Expand Down
4 changes: 4 additions & 0 deletions charts/bifrost-gateway-controller/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ controllerManager:

# Annotations to add to the deployment
annotations: {}

# Annotations to add to the pod
podAnnotations: {}

replicas: 1

deploymentStrategy:
Expand Down