Skip to content

Helm chart image tag default to Chart.appVersion instead of latest #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Michael Vittrup Larsen (michaelvl) merged 1 commit into from
Jun 2, 2023
Merged

Helm chart image tag default to Chart.appVersion instead of latest #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/bifrost-gateway-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## [UNRELEASED]

- Example text, add your PR info according to example below below this line. Do not bump chart version in Chart.yaml.
- chart image tag default to Chart.appVersion instead of latest. ([#194](https://github.com/tv2-oss/bifrost-gateway-controller/pull/194)) [@michaelvl](https://github.com/michaelvl)

## [0.1.7]

Expand Down
2 changes: 1 addition & 1 deletion charts/bifrost-gateway-controller/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ name: bifrost-gateway-controller-helm
description: Gateway API driven management of network infrastructure across Kubernetes and cloud infrastructure
type: application
version: 0.1.7
appVersion: "0.0.13"
appVersion: "0.0.21"
4 changes: 2 additions & 2 deletions charts/bifrost-gateway-controller/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# bifrost-gateway-controller-helm

![Version: 0.1.7](https://img.shields.io/badge/Version-0.1.7-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.0.13](https://img.shields.io/badge/AppVersion-0.0.13-informational?style=flat-square)
![Version: 0.1.7](https://img.shields.io/badge/Version-0.1.7-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.0.21](https://img.shields.io/badge/AppVersion-0.0.21-informational?style=flat-square)

Gateway API driven management of network infrastructure across Kubernetes and cloud infrastructure

Expand All @@ -13,7 +13,7 @@ Gateway API driven management of network infrastructure across Kubernetes and cl
| controllerManager.manager.image.name | string | `"bifrost-gateway-controller"` | |
| controllerManager.manager.image.pullPolicy | string | `"IfNotPresent"` | |
| controllerManager.manager.image.repository | string | `"ghcr.io/tv2-oss"` | |
| controllerManager.manager.image.tag | string | `"latest"` | |
| controllerManager.manager.image.tag | string | `""` | Image tag. Defaults to `.Chart.appVersion` |
| controllerManager.manager.livenessProbe.httpGet.path | string | `"/healthz"` | |
| controllerManager.manager.livenessProbe.httpGet.port | int | `8081` | |
| controllerManager.manager.livenessProbe.initialDelaySeconds | int | `15` | |
Expand Down
2 changes: 1 addition & 1 deletion charts/bifrost-gateway-controller/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ spec:
{{- if (contains "sha256:" .Values.controllerManager.manager.image.tag) }}
image: "{{ .Values.controllerManager.manager.image.repository }}/{{ .Values.controllerManager.manager.image.name }}@{{ .Values.controllerManager.manager.image.tag }}"
{{- else }}
image: "{{ .Values.controllerManager.manager.image.repository }}/{{ .Values.controllerManager.manager.image.name }}:{{ .Values.controllerManager.manager.image.tag }}"
image: "{{ .Values.controllerManager.manager.image.repository }}/{{ .Values.controllerManager.manager.image.name }}:{{ default .Chart.AppVersion .Values.controllerManager.manager.image.tag }}"
{{- end }}
imagePullPolicy: {{ .Values.controllerManager.manager.image.pullPolicy }}
name: manager
Expand Down
3 changes: 2 additions & 1 deletion charts/bifrost-gateway-controller/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ controllerManager:
image:
repository: ghcr.io/tv2-oss
name: bifrost-gateway-controller
tag: latest
# -- Image tag. Defaults to `.Chart.appVersion`
tag: ""
pullPolicy: IfNotPresent

resources:
Expand Down