Skip to content

Add json log support to helm chart #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Michael Vittrup Larsen (michaelvl) merged 2 commits into from
Jun 2, 2023
Merged

Add json log support to helm chart #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1d7676
Add json log support
michaelvl Jun 2, 2023
02f47af
Update changelog
michaelvl Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion charts/bifrost-gateway-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
## [UNRELEASED]

- Example text, add your PR info according to example below below this line. Do not bump chart version in Chart.yaml.
- chart image tag default to Chart.appVersion instead of latest. ([#194](https://github.com/tv2-oss/bifrost-gateway-controller/pull/194)) [@michaelvl](https://github.com/michaelvl)
- Add json log support to helm chart ([#195](https://github.com/tv2-oss/bifrost-gateway-controller/pull/195)) [@michaelvl](https://github.com/michaelvl)
- Chart image tag default to Chart.appVersion instead of latest. ([#194](https://github.com/tv2-oss/bifrost-gateway-controller/pull/194)) [@michaelvl](https://github.com/michaelvl)

## [0.1.7]

Expand Down
2 changes: 2 additions & 0 deletions charts/bifrost-gateway-controller/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ Gateway API driven management of network infrastructure across Kubernetes and cl
| controllerManager.manager.livenessProbe.httpGet.port | int | `8081` | |
| controllerManager.manager.livenessProbe.initialDelaySeconds | int | `15` | |
| controllerManager.manager.livenessProbe.periodSeconds | int | `20` | |
| controllerManager.manager.logging.format | string | `"json"` | Logging format. Defaults to text |
| controllerManager.manager.logging.level | string | `"debug"` | Log level [debug|info|error] |
| controllerManager.manager.rbac.additionalPermissions | list | `[]` | |
| controllerManager.manager.readinessProbe.httpGet.path | string | `"/readyz"` | |
| controllerManager.manager.readinessProbe.httpGet.port | int | `8081` | |
Expand Down
4 changes: 4 additions & 0 deletions charts/bifrost-gateway-controller/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ spec:
containers:
- args:
- --leader-elect
- --zap-log-level={{ .Values.controllerManager.manager.logging.level }}
{{ if eq .Values.controllerManager.manager.logging.format "json" -}}
- --zap-devel=false
{{- end }}
command:
- /bifrost-gateway-controller
{{- if (contains "sha256:" .Values.controllerManager.manager.image.tag) }}
Expand Down
14 changes: 14 additions & 0 deletions charts/bifrost-gateway-controller/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,20 @@
"livenessProbe": {
"type": "object"
},
"logging": {
"required": [
"format",
"level"
],
"properties": {
"format": {
"type": "string"
},
"level": {
"type": "string"
}
}
},
"readinessProbe": {
"type": "object"
},
Expand Down
6 changes: 6 additions & 0 deletions charts/bifrost-gateway-controller/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ controllerManager:
cpu: 10m
memory: 64Mi

logging:
# -- Logging format. Defaults to text
format: json
# -- Log level [debug|info|error]
level: debug

livenessProbe:
httpGet:
path: /healthz
Expand Down