Feature/add servicemonitor to helm chart#202
Merged
Michael Vittrup Larsen (michaelvl) merged 3 commits intomainfrom Jun 14, 2023
Merged
Feature/add servicemonitor to helm chart#202Michael Vittrup Larsen (michaelvl) merged 3 commits intomainfrom
Michael Vittrup Larsen (michaelvl) merged 3 commits intomainfrom
Conversation
Michael Vittrup Larsen (michaelvl)
requested review from
Sebastian Kalita (kuketro) and
Martin Villumsen (mvillumsen)
as code owners
Michael Vittrup Larsen (michaelvl)
force-pushed
the
feature/add-servicemonitor-to-helm-chart
branch
from
743c513 to
552701c
Compare
Michael Vittrup Larsen (michaelvl)
force-pushed
the
feature/add-servicemonitor-to-helm-chart
branch
from
552701c to
2c0b74a
Compare
Martin Villumsen (mvillumsen)
approved these changes
Jun 14, 2023
Michael Vittrup Larsen (michaelvl)
deleted the
feature/add-servicemonitor-to-helm-chart
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
ServiceMonitorCRD to the Helm chart for metrics endpoint discovery and configuration. The values-file has been changed to specifically indicate that metrics are Prometheus metrics.This PR also adds a test-deployment of Prometheus, which can be used to test the
ServiceMonitorCRD. The Helm chart schema has been recreated.Checklist