Limited character for name of targetgroup in GatewayClassBlueprint#221
Merged
Kent Vilhelmsen (kemv) merged 3 commits intomainfrom Jul 26, 2023
Merged
Limited character for name of targetgroup in GatewayClassBlueprint#221Kent Vilhelmsen (kemv) merged 3 commits intomainfrom
Kent Vilhelmsen (kemv) merged 3 commits intomainfrom
Conversation
Kent Vilhelmsen (kemv)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TargetGroups in AWS have a name character limit of 32. The current template generates a name that is
gw-<NAMESPACE>-<NAME>. This doesn't leave a lot of room in general, and if one deploys the same config to several clusters, then there is very little space for cluster identifiers, egcluster-1.To combat these issues, and issues with accidentally creating TargetGroups with too long names, this PR to the blueprint will cut off name if they are too long, and furthermore suffix names with the first 6 characters of a SHA1, which is generated over the entire name. This should ensure that resources should have different names if they contain their cluster identifier.
Checklist