Fix right margin of the carousel "next" button#13293
Conversation
|
Sorry I missed that—why is this needed exactly? Are those numbers not equal on both sides without this? |
|
Also, are we sure that it doesn't vary by browser? |
|
@mdo visually they're not equal. That's very annoying if we use, for example, symmetrical background. |
|
I'm inclined to not merge this one small tweak given it's a 1px change and is (I think?) entirely dependent on using Glyphicons. If folks use something else, I'm guessing it's not an issue? |
|
I'm not sure this has anything to do with Glyphicons, it's a problem with rounding in Chrome. If we take the carousel on the JavaScript page of the docs for example, the carousel container has a width of 816px, both |
|
Silly rounding. Probably fine for most other use cases though. For example, 15% of 940px (one of our grid tiers) is 141px. Given the carousel can be fluid, I see no reason to account for a small rounding error by the browser. |
The calculated offset of carousel's right-arrow differs with left-arrow on large viewport sizes. The problem was well described and illustrated here and here by @hnrch02. This PR is just a missing part of #13242