Merged
Conversation
vilgotf
commented
Feb 21, 2026
| } | ||
|
|
||
| fn parse_env<T>(key: &str) -> Result<Option<T>, Box<dyn Error>> | ||
| fn parse_env<F>(key: &str) -> Result<Option<F>, Box<dyn Error>> |
Member
Author
There was a problem hiding this comment.
The generic type of FromStr is idiomatically called F instead of T.
vilgotf
force-pushed
the
vilgotf/refactor
branch
from
0f42b2c to
ffeb14b
Compare
vilgotf
commented
Feb 21, 2026
src/main.rs
Outdated
| info!("Listening on http://{}", address); | ||
|
|
||
| let mut tasks = JoinSet::new(); | ||
| let tasks = TaskTracker::new(); |
vilgotf
force-pushed
the
vilgotf/refactor
branch
from
ffeb14b to
4c5f60c
Compare
Erk-
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies
mainby grouping related items and removing nesting.