chore: remove openjdk 8 from java dockerfile#701
Merged
manisha1997 merged 3 commits intotwilio-java-generation-modernisationfrom Nov 6, 2025
Merged
chore: remove openjdk 8 from java dockerfile#701manisha1997 merged 3 commits intotwilio-java-generation-modernisationfrom
manisha1997 merged 3 commits intotwilio-java-generation-modernisationfrom
Conversation
0e2e3ab
into
twilio-java-generation-modernisation
1 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Updated the base image to Eclipse Temurin 8 and added error handling for Maven installation. Also included Git installation and modified the git clone command to use HTTPS.
Checklist
make test-dockerpython examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-goand inspect the diffmake testintwilio-gotwilio-goIf you have questions, please create a GitHub Issue in this repository.