Fix Sync Config destroying .mcp.json#192
Merged
Merged
Conversation
write_project_config() now reads the existing .mcp.json before writing, backs it up, and merges DB-managed mcpServers into the existing config instead of overwriting the entire file. This mirrors the pattern already used by write_global_config() for ~/.claude.json. Refuses to overwrite if the existing file contains invalid JSON to prevent silent data loss.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.mcp.jsonwith{"mcpServers": {}}instead of mergingwrite_project_config()now reads the existing.mcp.json, backs it up, and merges DB-managedmcpServersinto the existing config — matching the pattern already used bywrite_global_config()for~/.claude.jsonTest plan
.mcp.jsoncontaining external MCPs, run Sync Config, verify they aren't destroyed