Add Urdu and various African languages#43
Merged
Conversation
cjchapman
reviewed
Jul 13, 2023
Contributor
|
I did a quick first pass at a review this evening. I plan to take another look at it tomorrow when I'm not so tired. 😀 |
cjchapman
suggested changes
Jul 13, 2023
Contributor
cjchapman
left a comment
cjchapman
left a comment
There was a problem hiding this comment.
I don't see anything else today, so there's just the changes I requested last night.
cjchapman
suggested changes
Jul 13, 2023
cjchapman
suggested changes
Jul 13, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
We want to add these:
data/ffdata/amdata/nqodata/so-Osmadata/panafricandata/shidata/urdata/vaiWhat?
All of the data files except
data/panafricananddata/soare the exact output of the Speakeasy Converter on CLDR 43.1.0.For
data/so, I started with the output from the Speakeasy Converter and added the characters from the Osmanya code chart.data/panafricancomes from a script I ran on the following file: Pan African Unicodes.txtI verified I'm able to load these languages into typekit/typekit.