Convert ioRuntime to lazy val#226
Merged
djspiewak merged 1 commit intotypelevel:series/1.xfrom Nov 19, 2021
ex0ns:lazy_val_context
Merged
Convert ioRuntime to lazy val#226djspiewak merged 1 commit intotypelevel:series/1.xfrom ex0ns:lazy_val_context
djspiewak merged 1 commit intotypelevel:series/1.xfrom
ex0ns:lazy_val_context
Conversation
By making ioRuntime a lazy val in the AsyncIOSpec the order in which the trait are mixed in the trait does not matter as much as it is current. Currently, by mixing AsyncIO trait BEFORE another trait/abstract class with a executionContext the execution fails with a Null Pointer Exception.
djspiewak
approved these changes
Nov 19, 2021
Member
djspiewak
left a comment
There was a problem hiding this comment.
Honestly I think this is a good change and a nice catch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By making ioRuntime a lazy val in the AsyncIOSpec the order in which the trait are mixed in the trait does not matter as much as it is current.
Currently, by mixing AsyncIO trait BEFORE another trait/abstract class with a executionContext the execution fails with a Null Pointer Exception.
The following code shows this issue:
I think that this change could prevent some mistake made when mixing multiple trait inside ScalaTest, I however don't have enough visibility on the impact caused by this change, and what would happen if multiple ExecutionContext were available when creating the
ioRuntime.Feel free to comment/reject/discuss. The workaround/fix is pretty easy to implement when using the library, but the NPE stacktrace is pretty confusing and not easy to debug when running the tests.