Limit ScalaTest dependency to its core library#418
Merged
djspiewak merged 1 commit intotypelevel:series/1.xfrom Feb 22, 2023
kaharlichenko:feature/narrow-down-scalatest-deps
Merged
Limit ScalaTest dependency to its core library#418djspiewak merged 1 commit intotypelevel:series/1.xfrom kaharlichenko:feature/narrow-down-scalatest-deps
djspiewak merged 1 commit intotypelevel:series/1.xfrom
kaharlichenko:feature/narrow-down-scalatest-deps
Conversation
djspiewak
requested changes
Feb 22, 2023
Member
djspiewak
left a comment
djspiewak
left a comment
There was a problem hiding this comment.
This seems extremely reasonable to me. :-) Needs a merge though.
Author
|
@djspiewak, I brought it up to date with the recent changes. Should I create another PR based on |
Member
I think at this point, 0.x is EOL, so it's fair to just concentrate on 1.x. |
djspiewak
approved these changes
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cats-effect-testing-scalatestonly depends on the classes fromscalatest-core.By narrowing down the dependency we let users cherry-pick specs and matchers they use in their project instead of pulling in the whole ScalaTest glory.