Add dual-effect Queue constructors, expose methods to change effect type of SyncRef and AsyncDeferred without mapK - #1889
Closed
bplommer wants to merge 7 commits into
Closed
Conversation
bplommer
marked this pull request as draft
April 6, 2021 09:10
bplommer
marked this pull request as ready for review
April 6, 2021 10:05
bplommer
force-pushed
the
transform-deferred
branch
from
April 6, 2021 11:37
d75ecc8 to
f248edb
Compare
Member
|
Interesting! Will need to think about this a bit… I can see the utility though. |
bplommer
changed the title
AsyncDeferred without mapKSyncRef and AsyncDeferred without mapK
Contributor
Author
|
After playing around with this some more, I've added a confirmed use case for this - dual-effect Queue constructors. |
Contributor
Author
|
Actually, the previous comment is misleading - the transform methods aren't needed for a dual-effect queue constructor. Anyway, I'll leave this PR as is for now and maybe open a separate one to just add the dual-effect constructor. |
Member
|
Given that we can now easily convert between |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation for this is to be able to allocate resources in the form
Resource[F, Thing[G]]where the same state needs to be accessed inGby theThingbut in F for theResource.I'll add tests and typeclass instances if this is approved in principle, and do something similar for Ref.