Skip to content

Add Scala3 / JDK17 job to CI#2969

Merged
djspiewak merged 1 commit into
typelevel:series/3.3.xfrom
armanbilge:topic/ci-scala3-jdk17
Apr 26, 2022
Merged

Add Scala3 / JDK17 job to CI#2969
djspiewak merged 1 commit into
typelevel:series/3.3.xfrom
armanbilge:topic/ci-scala3-jdk17

Conversation

@armanbilge

Copy link
Copy Markdown
Member

Forgot my promise to do this in #2857 (comment) :)

Expecting the first commit to fail with the MiMa issues. Will follow-up with exclusions.

@armanbilge

Copy link
Copy Markdown
Member Author

Huh. I can no longer reproduce the MiMa issues locally 🤔

@armanbilge

Copy link
Copy Markdown
Member Author

Oh lol I guess the filters were already in place 😅 I must have added them in anger when trying to get MiMa to pass on my local, woops 🙃

cats-effect/build.sbt

Lines 526 to 535 in 0177c4a

ProblemFilters.exclude[DirectMissingMethodProblem](
"cats.effect.tracing.Tracing.bumpVersion"),
ProblemFilters.exclude[DirectMissingMethodProblem](
"cats.effect.tracing.Tracing.castEntry"),
ProblemFilters.exclude[DirectMissingMethodProblem](
"cats.effect.tracing.Tracing.match"),
ProblemFilters.exclude[DirectMissingMethodProblem]("cats.effect.tracing.Tracing.put"),
ProblemFilters.exclude[DirectMissingMethodProblem](
"cats.effect.tracing.Tracing.version")
)

@djspiewak djspiewak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this actually remove the Scala 3 + JDK 17 job?

@armanbilge

Copy link
Copy Markdown
Member Author

@djspiewak

Copy link
Copy Markdown
Member

Oh, it's the exclusion matrix. Sorry, not enough coffee

@djspiewak
djspiewak merged commit 8ebb6be into typelevel:series/3.3.x Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants