Removed implicit modifiers on deprecated instance to avoid unavoidable warnings#4180
Merged
armanbilge merged 3 commits intotypelevel:series/3.xfrom Nov 24, 2024
Merged
Conversation
armanbilge
requested changes
Nov 22, 2024
Member
armanbilge
left a comment
armanbilge
left a comment
There was a problem hiding this comment.
I'm not sure if this is the change we want to make. The reason we left it as an implicit is so that this instance is still available in contexts that don't have MonadCancelThrow available (instead of an implicit-not-found compilation error). If you receive the deprecation message, the correct fix is to bring MonadCancelThrow into scope.
armanbilge
previously approved these changes
Nov 24, 2024
Member
armanbilge
left a comment
armanbilge
left a comment
There was a problem hiding this comment.
@lenguyenthanh tried a different fix in 3f79b9d (thanks!) but we couldn't get it to work. So I think this is the best option to fix things.
armanbilge
reviewed
Nov 24, 2024
Co-authored-by: Arman Bilge <armanbilge@gmail.com>
armanbilge
approved these changes
Nov 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix HEAD builds.