Improve String generation - #385
Merged
Merged
Conversation
Contributor
Author
|
what do you think @regadas ? |
regadas
approved these changes
Feb 26, 2022
regadas
left a comment
regadas
left a comment
Contributor
There was a problem hiding this comment.
Agreed! I think this is better too! 👍
i10416
pushed a commit
to i10416/cats-parse
that referenced
this pull request
Mar 20, 2022
i10416
pushed a commit
to i10416/cats-parse
that referenced
this pull request
Mar 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were using scalacheck
Arbitrary.arbitrary[String]which generates strings from a huge space. The problem is that the chance you randomly generate anything that will parse will be very low.Here we improve is somewhat by choosing strings from three spaces:
('a', 'A', 'b', 'B', ' '), printable ascii, and all unicode.The idea is that some laws that might not fail for all unicode (because we just generate parsers and strings that never match) might fail if we restrict the string space enough.
No tests failed, but still I think it is better.