Update Build#1
Merged
Merged
Conversation
isomarcte
commented
Jan 22, 2022
isomarcte
commented
Member
- Update various versions
- Add Scala3
- Add Scalafix/Scalafmt
- Also add liancheng's ogranize imports scalafix tool
- Remove Main/MainSpec
- Switch to sbt-typelevel plugin
* Update various versions
* Add Scala3
* Add Scalafix/Scalafmt
* Also add liancheng's ogranize imports scalafix tool
* Remove Main/MainSpec
* Switch to sbt-typelevel plugin
Member
Author
armanbilge
reviewed
Jan 22, 2022
| @@ -1,23 +1,16 @@ | |||
| import sbtcrossproject.CrossPlugin.autoImport.{crossProject, CrossType} | |||
Member
There was a problem hiding this comment.
Suggested change
| import sbtcrossproject.CrossPlugin.autoImport.{crossProject, CrossType} |
Auto-imports are, auto-imported :)
| @@ -0,0 +1 @@ | |||
| ThisBuild / version := "0.0.1-SNAPSHOT" | |||
Member
There was a problem hiding this comment.
sbt-typelevel has a git-based versioning scheme. You should add ThisBuild / tlBaseVersion := "0.0" to the primary build.
Suggested change
| ThisBuild / version := "0.0.1-SNAPSHOT" |
| addSbtPlugin("ch.epfl.scala" % "sbt-scalafix" % "0.9.28") | ||
| addSbtPlugin("com.github.cb372" % "sbt-explicit-dependencies" % "0.2.16") | ||
| addSbtPlugin("com.timushev.sbt" % "sbt-updates" % "0.5.3") | ||
| addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.4.2") |
Member
There was a problem hiding this comment.
sbt-typelevel gets you the latest.
Suggested change
| addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.4.2") |
Comment on lines
12
to
16
| lazy val `cats-uri` = project | ||
| .in(file(".")) | ||
| .disablePlugins(MimaPlugin) | ||
| .enablePlugins(NoPublishPlugin) | ||
| .aggregate(core.jvm, core.js) |
Member
There was a problem hiding this comment.
Suggested change
| lazy val `cats-uri` = project | |
| .in(file(".")) | |
| .disablePlugins(MimaPlugin) | |
| .enablePlugins(NoPublishPlugin) | |
| .aggregate(core.jvm, core.js) | |
| lazy val root = tlCrossRootProject.aggregate(core) |
| micrositeDescription := "A URI with Cats instances", | ||
| ) | ||
| } | ||
| lazy val site = project.in(file("site")).disablePlugins(MimaPlugin).dependsOn(core.jvm) |
Member
There was a problem hiding this comment.
Suggested change
| lazy val site = project.in(file("site")).disablePlugins(MimaPlugin).dependsOn(core.jvm) | |
| lazy val site = project.in(file("site")).enablePlugins(TypelevelSitePlugin).dependsOn(core.jvm) |
You'll also need to add a dependency to sbt-typelevel-site.
44 tasks
rossabaker
reviewed
Jan 22, 2022
rossabaker
left a comment
rossabaker
left a comment
Member
There was a problem hiding this comment.
I didn't even remember there was a skeleton here. You're in good hands with Arman. I'll create a project team for it.
armanbilge
approved these changes
Jan 22, 2022
Member
|
@armanbilge Are you hanging around to help with the project, or just here for the build? 😄 |
Member
|
Oops. I did not look carefully at the build status before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.