make sure that EitherT MonadError syntax works the old way - #2029
Merged
Conversation
LukaJCB
reviewed
Nov 14, 2017
|
|
||
| import ExtraRegressionSuite._ | ||
|
|
||
| class ExtraRegressionSuite extends CatsSuite { |
Contributor
Author
There was a problem hiding this comment.
oops I did a rename but didn't include the renamed file in the git. just pushed. good catch.
LukaJCB
reviewed
Nov 14, 2017
LukaJCB
left a comment
LukaJCB
left a comment
Member
There was a problem hiding this comment.
LGTM except for that one comment I left below :)
LukaJCB
previously approved these changes
Nov 14, 2017
johnynek
previously approved these changes
Nov 14, 2017
kailuowang
force-pushed
the
fix-me-syntax-eitherT
branch
from
November 14, 2017 18:04
67f5861 to
1a8e545
Compare
Codecov Report
@@ Coverage Diff @@
## master #2029 +/- ##
=======================================
Coverage 95.09% 95.09%
=======================================
Files 301 301
Lines 4953 4953
Branches 125 125
=======================================
Hits 4710 4710
Misses 243 243
Continue to review full report at Codecov.
|
Contributor
Author
LukaJCB
approved these changes
Nov 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flipped the priority sequence between the two
MonadErrorinstances forEitherTso that the syntax goes back to the behavior prior to 1.0-RC1. If user need theMonadErrorsyntax with theMonadErrorinstance that deals with the Error type on the innerF, they would need to create a local implicit instance that takes higher precedence, see theRegressionSuitefor examplefixes #2022