Add Align for Stream - #3144
Merged
Merged
Conversation
LukaJCB
approved these changes
Nov 13, 2019
LukaJCB
left a comment
Member
There was a problem hiding this comment.
Looks good to me 👍 Just a simple oversight on my end
Contributor
Author
|
Great, thanks @LukaJCB! |
Codecov Report
@@ Coverage Diff @@
## master #3144 +/- ##
==========================================
- Coverage 93.28% 90.93% -2.35%
==========================================
Files 376 375 -1
Lines 7323 7300 -23
Branches 174 189 +15
==========================================
- Hits 6831 6638 -193
- Misses 492 662 +170
Continue to review full report at Codecov.
|
kailuowang
approved these changes
Nov 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3076 adding
Align[Stream]with the same implementation asAlign[LazyList]. I don't think there's any reason not to include these, @LukaJCB?I've also added a package-private
Align.alignWithIteratorhelper method to clean up some repetition inAligndefinitions.