Skip to content

Add Align lawful tests for Option instance - #3350

Merged
LukaJCB merged 5 commits into
typelevel:masterfrom
gagandeepkalra:test/align/option
Mar 11, 2020
Merged

Add Align lawful tests for Option instance#3350
LukaJCB merged 5 commits into
typelevel:masterfrom
gagandeepkalra:test/align/option

Conversation

@gagandeepkalra

Copy link
Copy Markdown
Contributor

while back-porting Align to Scala 2.11, noticed we are missing tests for Option instance.

@travisbrown

Copy link
Copy Markdown
Contributor

Can you rebase or merge master and add the import? Thanks for catching this!

@travisbrown

Copy link
Copy Markdown
Contributor

I think it still needs the cats.Align import (we recently changed the tests to use imports instead of package nesting in order to match usage more directly).

@gagandeepkalra

Copy link
Copy Markdown
Contributor Author

Sorry, I did that in a hurry.

@travisbrown travisbrown left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gagandeepkalra. The failure in CI was unrelated, so I restarted the build and opened #3353 to track it. +1 on green.

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #3350 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3350      +/-   ##
==========================================
+ Coverage   93.32%   93.34%   +0.01%     
==========================================
  Files         378      378              
  Lines        7689     7692       +3     
  Branches      206      203       -3     
==========================================
+ Hits         7176     7180       +4     
+ Misses        513      512       -1
Flag Coverage Δ
#scala_version_212 93.4% <ø> (+0.04%) ⬆️
#scala_version_213 93.12% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
core/src/main/scala/cats/instances/either.scala 100% <0%> (ø) ⬆️
core/src/main/scala/cats/syntax/either.scala 83.33% <0%> (+0.24%) ⬆️
core/src/main/scala/cats/instances/option.scala 100% <0%> (+1.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc23079...f95677e. Read the comment docs.

@gagandeepkalra

Copy link
Copy Markdown
Contributor Author

Thank you, Sir 🙂

@LukaJCB
LukaJCB merged commit 4351ea3 into typelevel:master Mar 11, 2020
@travisbrown travisbrown added this to the 2.2.0-M1 milestone Mar 20, 2020
@gagandeepkalra
gagandeepkalra deleted the test/align/option branch June 5, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants