Rollback the rollback to Scala.js 1.5.1 - #4048
Merged
Merged
Conversation
Contributor
|
Yes, I can confirm: I tried running |
satorg
approved these changes
Nov 19, 2021
satorg
left a comment
satorg
left a comment
Contributor
There was a problem hiding this comment.
GitHub actions have succeeded – seems it fixes the build indeed.
Member
Author
|
Since the build is broken and affecting a couple other PRs, I'm going to merge this hastily. If anyone doesn't like it, speak up here before the next release. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build on #4018 was broken and merged anyway. Scala.js compatibility has been good enough, and enough of the ecosystem has moved on, I no longer think it's worth trying to keep this one pinned.