Add copyright notices and Scala license for code derived from the standard library - #4196
Merged
danicheg merged 1 commit intoApr 25, 2022
Conversation
rossabaker
approved these changes
Apr 25, 2022
johnynek
approved these changes
Apr 25, 2022
satorg
reviewed
Apr 25, 2022
Comment on lines
+682
to
+693
| * | ||
| * The method does not call `length` directly; its running time | ||
| * is `O(length min len)` instead of `O(length)`. | ||
| * | ||
| * | ||
| * @param len the test value that gets compared with the length. | ||
| * @return a negative value if `this.length < len`, | ||
| * zero if `this.length == len` or | ||
| * a positive value if `this.length > len`. | ||
| * @note an adapted version of | ||
| [[https://github.com/scala/scala/blob/v2.13.8/src/library/scala/collection/Iterable.scala#L272-L288 Iterable#sizeCompare]] | ||
| from Scala Library v2.13.8 is used in a part of the implementation. | ||
| * | ||
| * |
Contributor
There was a problem hiding this comment.
Sorry, I completely missed this part. Seems that it is not derived from the Scala library anymore. It was so initially indeed, but then it was re-worked for the sake of optimization. Moreover, Cats has never been released with the original Scala-derived version. cc @DavidGregory084 @johnynek
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4189 by adding the Scala license to the COPYING file, and adding the suggested copyright notice to code adapted from the standard library.
Contributed on behalf of the @opencastsoftware open source team. 👋