Skip to content

VoidError - can be applied to any yield type #4388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
diesalbla wants to merge 1 commit into from
Closed

VoidError - can be applied to any yield type #4388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/scala/cats/ApplicativeError.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ trait ApplicativeError[F[_], E] extends Applicative[F] {
* @see [[handleError]] to map to an `A` value instead of `Unit`.
* @see [[https://github.com/typelevel/cats-effect/issues/3152 cats-effect#3152]]
*/
def voidError(fu: F[Unit]): F[Unit] = handleError(fu)(Function.const(()))
def voidError(fu: F[_]): F[Unit] = handleError(fu)(Function.const(()))

@armanbilge armanbilge Feb 1, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is correct. You can get runtime cast errors. See a similar situation in:

@satorg satorg Feb 2, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, there was a discussion about it in the initial PR:
#4324 (comment)


/**
* Handle errors by turning them into [[scala.util.Either]] values.
Expand Down