Lambda linting etc. - #54
Merged
Merged
Conversation
armanbilge
commented
Nov 19, 2021
Comment on lines
+53
to
+56
| val json = result.asJson | ||
| val bb = Printer.noSpaces.printToByteBuffer(json) | ||
| val ch = Channels.newChannel(output) | ||
| ch.write(bb) |
Member
Author
There was a problem hiding this comment.
I opened circe/circe#1855 which would let us write directly to the OutputStream, but not sure what's going on there rn.
Member
There was a problem hiding this comment.
Looks like there are new maintainers, but they probably need to get settled in :)
armanbilge
marked this pull request as ready for review
December 13, 2021 03:05
Co-authored-by: =?UTF-8?q?Jakub=20Koz=C5=82owski?= <kubukoz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #51.