Switch to a hand-maintained Node.js facade - #2918
Merged
Merged
Conversation
Member
Author
|
I published cc479f4 as
|
armanbilge
marked this pull request as ready for review
June 5, 2022 16:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2777. This replaces the 700+ files auto-generated by Scalably Typed with 10 files focused on the Node.js APIs we actually use. This lets us remove the ScalablyTyped and Bundler plugins and lockfiles.
One of the hazards of a hand-maintained facade is that we now rely entirely on runtime tests to know if any of this works, since a facade could be completely wrong and is not statically verified against anything. So there could be some regressions due to this change for any APIs lacking coverage. We can slowly improve this.