Pass Through Unmodified String On Failure In Mapping Step#82
Merged
isomarcte merged 2 commits intoFeb 15, 2023
Merged
Conversation
Previously when we encountered a disallowed code point in the mapping step, we replaced it with the Unicode replacement character 0xfffd. This is because UTS-46 dictates that we should not render a string with disallowed code points back to the user. However, the UTS-46 validation steps, which occur after the mapping step, require operating on the input with the disallowed code points in place. To facilitate this, the `MappingException` has been changed to return both `unsafePartiallyMappedInput` and `renderablePartiallyMappedInput` values. `unsafePartiallyMappedInput` is the mapped input, but disallowed code points are left in place and should never be rendered to the user. `renderablePartiallyMappedInput` is the mapped input, with disallowed code points represented as 0xfffd.
In JRE8 `.flip` returns `Buffer` not the concrete buffer type, e.g. `IntBuffer`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously when we encountered a disallowed code point in the mapping step, we replaced it with the Unicode replacement character 0xfffd. This is because UTS-46 dictates that we should not render a string with disallowed code points back to the user.
However, the UTS-46 validation steps, which occur after the mapping step, require operating on the input with the disallowed code points in place.
To facilitate this, the
MappingExceptionhas been changed to return bothunsafePartiallyMappedInputandrenderablePartiallyMappedInputvalues.unsafePartiallyMappedInputis the mapped input, but disallowed code points are left in place and should never be rendered to the user.renderablePartiallyMappedInputis the mapped input, with disallowed code points represented as 0xfffd.