Make default CI steps togglable - #275
Merged
Merged
Conversation
armanbilge
changed the title
DavidGregory084
approved these changes
May 17, 2022
DavidGregory084
left a comment
DavidGregory084
left a comment
Contributor
There was a problem hiding this comment.
Looks great to me! 💯
armanbilge
commented
May 17, 2022
Comment on lines
+35
to
+36
| lazy val tlCiScalafmtCheck = | ||
| settingKey[Boolean]("Whether to do scalafmt check in CI (default: false)") |
Member
Author
Member
Author
|
@DavidGregory084 feel free to merge this branch into #274 and keep going, I never force-push :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #247.
This PR adds settings to the
TypelevelCiPluginto toggle various steps in the generated CI workflow.This makes it easy for individual builds/projects to turn these steps on/off, so that a project can still get scalafmt checks for example even if they don't want header checks or scalac settings.
In sbt-typelevel v0.5.0 I will make all these false by default in the
TypelevelCiPlugin, and enable them as appropriate in theTypelevelCiReleasePluginandTypelevelPlugin. This will make it easier to use theTypelevelCiPluginfor non-publishing applications developed on GitHub.