Scala Native - #703
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #703 +/- ##
==========================================
+ Coverage 87.08% 87.16% +0.07%
==========================================
Files 110 111 +1
Lines 1487 1504 +17
Branches 105 107 +2
==========================================
+ Hits 1295 1311 +16
- Misses 192 193 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
holy crap |
mpilquist
reviewed
Nov 24, 2022
| ) | ||
| .platformsSettings(JVMPlatform, JSPlatform)( | ||
| libraryDependencies ++= Seq( | ||
| "com.beachape" %%% "enumeratum" % "1.7.1-SNAPSHOT", |
Member
There was a problem hiding this comment.
Does this still need to be a snapshot now that's it's moved to JVM/JS
Member
There was a problem hiding this comment.
Nevermind, I see that was changed in a subsequent commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this is fun! All tests are passing :) but a couple notes: