Dotty diff minimizing - #1079
Merged
Merged
Conversation
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <carlos.m.quiroz@gmail.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
…check test Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
This reverts commit 7bf3b7d.
Improve `cfor` / `fastFor` semantics, docs
cquiroz
reviewed
Oct 19, 2021
| def apply[A: Eq: Arbitrary](implicit _pred: Predicate[A]) = new RingLaws[A] { | ||
| def Arb = implicitly[Arbitrary[A]] | ||
| def pred = _pred | ||
| override def Equ = super.Equ // To remove the implicit modifier |
Collaborator
There was a problem hiding this comment.
This took me quite a while to figure out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I reviewed all of #1067 and tried to minimize the diff where possible while passing through. Hopefully I didn't break anything 😅
One of biggest reverts was putting
()back for the random methods, these are side-effecting and should not have been removed.