feat: Add Density units (k|m|µ|n)g per (k|m|µ|n)l#509
Merged
Conversation
Add density units for all combinations of kilo, milli, micro and nano grams per kilo, milli, micro and nano litres. Fixed bug with existing multiplication conversion and explicitly typed all return values for Density class and object.
cquiroz
reviewed
Jan 6, 2022
|
|
||
| def *(that: Volume): Mass = Kilograms(this.value * that.toCubicMeters) | ||
| def *(that: Volume): Mass = Kilograms(this.toKilogramsPerCubicMeter * that.toCubicMeters) | ||
|
|
Contributor
There was a problem hiding this comment.
Is this the fix that you mentioned?
cquiroz
approved these changes
Jan 6, 2022
cquiroz
left a comment
cquiroz
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot for your PR and for including tests
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add density units for all combinations of kilo, milli, micro and nano
grams per kilo, milli, micro and nano litres.
Fixed bug with existing multiplication conversion and explicitly typed
all return values for Density class and object.