Add php-parser Node to reflection data and cleanup in the end#78
Open
Add php-parser Node to reflection data and cleanup in the end#78
Conversation
vudaltsov
force-pushed
the
72-add-node-to-data
branch
from
3348653 to
cca91cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #72
For now I've decided to add
PhpParser\Nodeto root reflections' data maps only (constant/function/class). This is because properties, class constants and attributes are sometimes bundled together and it's hard to decide, what node to put asData::Node. I think that for now this is more than enough :)