Nested requests returning 404

[therebelrobot]

So I have a json file that has the following schema:

{
  "environments": [
    {
      "id": 12,
      "reports": [
        {
          "id": 17
        },
        {
          "id": 25
        }
      ]
    },
    {
      "id": 19,
      "reports": [
        {
          "id": 22
        },
        {
          "id": 30
        }
      ]
    }
  ]
}

/environments works, as does /environments/12, so I figured I could use the route /environments/12/reports to return that array, but it's returning a 404 instead. Am I doing something wrong here?

My env:

• Mac OS X Yosemite
• NVM 0.24.0
• io.js 1.8.1
• json-server 0.7.3

[typicode]

For nested resources to work, you need to structure your db.json this way:

{
  "environments": [
    { "id": 12 },
    { "id": 19 }
  ],
  "reports": [
    { "id": 17, "environmentId": 12 }
    { "id": 25, "environmentId": 12 }
  ]
}

Then /environments/12/reports should return reports that have environmentId === 12

[therebelrobot]

Ah. kk. Thanks for the update. I'll try that and close this if it works.

[therebelrobot]

Worked like a charm. Would you be averse to a PR clarifying nested requests in README.md? I can have it submitted in a few minutes if you want it.

[therebelrobot]

One more question: should /environments/12/reports/17 work? I thought it was earlier today, but now I'm running it and no dice. 404 error.

[therebelrobot]

Hrmmm... looks like not. The nested routes are being handled statically. I'll take a look at it tonight and see if I can't add nested routing ad infinitum.

[typicode]

You're right, one level of nesting is supported.
Except if there's many people that need infinite nesting, it's not wished for the moment.

Mainly to limit code complexity and also based on the idea that if you know the report id, you can directly make a request to get it /reports/17

However a workaround could be to use filters, there's no limit to how much you can use:

/reports?id=17&environmentId=12&...

There's also an (old) article but still interesting about deep nesting:
http://weblog.jamisbuck.org/2007/2/5/nesting-resources

Do you need deep nesting because of a particular front-end library?

PS: thanks for the PR, I'll take a look at it as soon as I can :)

[therebelrobot]

Thanks for the resource! I'm definitely gonna be going over that.

That being said, the API I'm mocking isn't in my control, I'm building a front-end for it, and I'm just trying to mimic it as closely as possible. It's not that difficult of an update, but if that feature isn't needed in the library as a whole, I'll just source my fork with the changes needed, no worries.

Let me know if there needs to be any changes in that PR, I'm happy to jump in and fix stuff.

[typicode]

Great.

Not sure if it's the best way to fill the gaps for your API, but using the project as a module you could do something like this:

var jsonServer = require('json-server')

var server = jsonServer.create()
server.use(jsonServer.defaults)

// Simple hack
server.use('/environments/:environmentId/reports/:reportId', function (req, res) {
  res.redirect('/reports/' + req.params.reportId)
})

server.use(jsonServer.router('db.json'))

server.listen(3000)

I've not tested code, but it should work.

[therebelrobot]

Ok, so here's what I got: https://github.com/therebelrobot/json-server/tree/feature/nested-calls

I rebuilt router.js quite a bit, it was hard-coding the routes and duplicating code from show to list. I changed the name of list to parse, and routed all calls through it (it now checks all the ids and manages sub-resources). I split out the show function to find (which handles the actual object finding in lowdb) and present (which handles sorting, paging, etc), making things a little more modular. Also added most internal objects that were in list to req._internal so it could be called by subsequent middleware.

I ran all of it through the test suite, also added 4 more tests for more nested calls. Everything is passing 100%.

Also added a coverage folder, and verified >99% code coverage of the new router.

I know you weren't looking at this kind of feature, but if you want a PR for it after all, lemme know :)

[ir-g]

@typicode @therebelrobot

I would love to see this PR'd in as I really would love to see nested calls working, even if it was just an optional feature.

I wouldn't normally comment, but this feature would be super-useful.

[therebelrobot]

@isaacrg As per @typicode's desire to keep things simple, I've forked the repo and republished it. Here it is: https://github.com/therebelrobot/json-mock

I'll close this issue now :)