Remove GVFS.Service.UI (dead code)#3
Closed
tyrielv wants to merge 1 commit into
Closed
Conversation
The Service.UI process displayed Windows toast notifications, but only the MountFailure notification was actively sent, and it provided no useful value. Removing eliminates XmlSerializer and WinRT COM interop dependencies that would block NativeAOT compilation. Removes: project, unit tests, installer integration, service launch logic, notification handler, diagnostics log collection, and the Microsoft.Windows.SDK.Contracts package. Assisted-by: Claude Opus 4.6 Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove GVFS.Service.UI (dead code)
tyrielv/net10-central-packages. GitHub will retarget tomasteronce microsoft#1937 merges.Summary
Remove GVFS.Service.UI entirely — dead code. The Service.UI process displayed Windows toast notifications, but only the MountFailure notification was actively sent, and it provided no useful value.
Removing eliminates XmlSerializer and WinRT COM interop dependencies that would block NativeAOT compilation.
What was removed
GVFSToastRequestHandlerTests.csMicrosoft.Windows.SDK.Contracts(only consumer)Review guide
NotificationHandler.cs— gutted to no-op rather than deleted, in case callers existSetup.iss— verify all 4 Service.UI-related procedures and calls removedGVFSService.Windows.cs— verifyLaunchServiceUIIfNotRunningand call site removedVerification
Context
Phase 2D of .NET 10 NativeAOT migration. Stacked on microsoft#1937 (central packages).