Skip to content

Add more EventInstance bindings#58

Open
IzaZed wants to merge 5 commits into
tyrylu:masterfrom
IzaZed:add_bindings
Open

Add more EventInstance bindings#58
IzaZed wants to merge 5 commits into
tyrylu:masterfrom
IzaZed:add_bindings

Conversation

@IzaZed

@IzaZed IzaZed commented Aug 5, 2024

Copy link
Copy Markdown
Contributor

Add these bindings (and python properties where appropriate) to EventInstance:

  • getCPUUsage
  • getPitch
  • setPitch
  • getReverbLevel
  • setReverbLevel
  • Release
  • getTimelinePosition
  • setTimelinePosition
  • getVolume
  • setVolume
  • isVirtual

@tyrylu

tyrylu commented Aug 11, 2024

Copy link
Copy Markdown
Owner

Why do you think having the get|set methods and the properties at the same time is beneficiary? Also, I know, I don't like it myself, but adding tests would be helpful as well.

@IzaZed

IzaZed commented Aug 18, 2024

Copy link
Copy Markdown
Contributor Author

ah, that was just for API completion, only using properties works just as well for me though
I'll remove the methods and add tests

@tyrylu

tyrylu commented Aug 18, 2024

Copy link
Copy Markdown
Owner

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants