Cannot use redirect option with negated domain

[Jtasiu]

Prerequisites

• I verified that this is not a filter issue
  • Filter issues MUST be reported at filter issue tracker
• This is not a support issue or a question
  • Support issues and questions are handled at /r/uBlockOrigin
• I performed a cursory search of the issue tracker to avoid opening a duplicate issue
  • Your issue may already be reported.
• I tried to reproduce the issue when...
  • uBlock Origin is the only extension
  • uBlock Origin with default lists/settings
  • using a new, unmodified browser profile
• I am running the latest version of uBlock Origin
• I checked the documentation to understand that the issue I report is not a normal behavior

Description

I am writing some filters but I noticed the below kind didn't work

*pop.js$important,script,redirect=noopjs,domain=~site.com

Why negated domains don't work at all with redirect option? I would like to create filters to do this as I don't mind performance hit, can deal with breakage myself and would rather redirect some file names totally. Is it possible to add a way to do this?

Seems to work for a.com|~b.com and other way around, but not for simple ~a.com (no redirection at all)

Tested on https://www.wykop.pl/ and https://www.wp.pl/ with variants of */xgemius.js$script,redirect=noopjs,domain=wp.pl|~wykop.pl

See also gorhill/uBlock#3590

---

https://github.com/gorhill/uBlock/blob/23cd2e1d4a264b3d56d497d20f70f020983bf6c2/src/js/redirect-engine.js#L353

[uBlock-user]

another limitation of redirect directive it seems..

[gorhill]

The issue is that redirect= should have been made to strictly create redirection directives, not blocking filters -- I keep repeating this.

The issue here can be solved only if changing all the semantic of the redirect= filters, which of course can't happen. OP's issue can be resolved by overriding the blanket redirection with another filter.

[uBlock-user]

The issue here can be solved only if changing all the semantic of the redirect= filters, which of course can't happen.

So this is a won't fix ?

[gorhill]

So this is a won't fix ?

I could make the filter *pop.js$important,script,redirect=noopjs,domain=~site.com work, but it would have to be understood that if ever a network request of type script from site.com pattern-matching pop.js is ever blocked by whatever mean, it would be redirected to noopjs.

[uBlock-user]

You mean except from site.com ? as thats negated.

[gorhill]

I meant what I wrote.

[uBlock-user]

Why would it apply on the negated domain ?

Filter will be split into two parts: blocking part and redirecting. Negation will disable blocking. Blocking by any other means/filters will trigger redirection.

[uBlock-user]

Wouldn't negation affect redirection too ? If that's the case, then there's no point in adding a negated domain with redirection.

[Jtasiu]

@gwarser

Seems to work for a.com|~b.com and other way around, but not for simple ~a.com (no redirection at all)

Don't think the filter you wrote works for negated...to me looks like a.com will follow the filter rule but the negated domain will not work with the filter (it will be discarded).

@gorhill

OP's issue can be resolved by overriding the blanket redirection with another filter.

Not sure what that another filter is...please post example?