This repository was archived by the owner on May 4, 2022. It is now read-only.
WCP-441 Adds LTI-Launch as a widget type#562
Merged
Conversation
apetro
approved these changes
Jan 20, 2017
Contributor
apetro
left a comment
apetro
left a comment
There was a problem hiding this comment.
Discussed f2f potential refactor to eliminate need for LTI-specific widget by incorporating LTI form render/post functionality into external microservice. I still think that's a good idea, would allow the within-angularjs-portal amount of LTI-specific stuff to be zero, for this to be just a URL from the perspective of things outside the microservice. Encapsulation for the win.
Progress is progress. Let's do this, and refactor to that if justified in the course of future work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new type of widget lti-launch