This repository was archived by the owner on May 4, 2022. It is now read-only.
fix(license): remove scss auto-license in /docs#693
Merged
davidmsibley merged 1 commit intouPortal-Attic:masterfrom Sep 20, 2017
Merged
fix(license): remove scss auto-license in /docs#693davidmsibley merged 1 commit intouPortal-Attic:masterfrom
davidmsibley merged 1 commit intouPortal-Attic:masterfrom
Conversation
SCSS files used in jekyll have to start with a front matter comment.
ChristianMurphy
approved these changes
Sep 15, 2017
Contributor
ChristianMurphy
left a comment
ChristianMurphy
left a comment
There was a problem hiding this comment.
Good catch, LGTM 👍
Thanks @vertein! 🙇♂️
Contributor
Author
|
The CI failure is being caused by linting errors in this changeset: #692 |
apetro
approved these changes
Sep 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our github pages were looking funky:
vs, what it should look like
SCSS files used in jekyll have to start with a front matter comment and can't start with a header license. This excludes scss files in the docs directory from having the license header added automatically and fixes the existing comment to move beneath the front matter comment.
Similar to uPortal-Attic/uportal-app-framework#527
{Substantive content goes here. Summarize the changeset and why the changeset.}
Contributor License Agreement adherence: