This repository was archived by the owner on May 4, 2022. It is now read-only.
fix(ui): Fix clipping app options on small screens#713
Merged
thevoiceofzeke merged 2 commits intouPortal-Attic:masterfrom Sep 29, 2017
Merged
fix(ui): Fix clipping app options on small screens#713thevoiceofzeke merged 2 commits intouPortal-Attic:masterfrom
thevoiceofzeke merged 2 commits intouPortal-Attic:masterfrom
Conversation
davidmsibley
approved these changes
Sep 28, 2017
ChristianMurphy
approved these changes
Sep 28, 2017
apetro
approved these changes
Sep 28, 2017
| <md-icon>add</md-icon> Add more to home | ||
| </span> | ||
| <span ng-if="!GuestMode" hide-gt-sm> | ||
| <md-icon>add</md-icon> Add more |
Contributor
There was a problem hiding this comment.
Does this need some kind of ARIA treatment so that a non-visual user will understand what it is inviting the user to add more of?
apetro
reviewed
Sep 28, 2017
| <!-- MEDIUM AND LARGE SCREENS --> | ||
| <div layout="row" layout-align="end center" hide-xs> | ||
| <md-button ng-href="apps" class="md-primary"> | ||
| <md-button ng-href="apps" class="md-primary" aria-label="Add more apps to home"> |
Contributor
There was a problem hiding this comment.
How about aria-label="Browse app directory" so that the same aria-label makes sense whether in guest mode or not?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
Screenshots
Contributor License Agreement adherence: