This repository was archived by the owner on May 4, 2022. It is now read-only.
drop duplicate fnames when migrating layout from old layout backend#936
Merged
drop duplicate fnames when migrating layout from old layout backend#936
Conversation
apetro
force-pushed
the
drop-duplicates-during-layout-migrate
branch
from
e530c30 to
c135289
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new layout backend assures no duplicates.
But when migrating layouts, this front end would POST the copied over layout to the new backend, but did not read the layout back out of the new backend, and so did not immediately benefit from the backend's de-duplication.
This Pull Request adds using Set to filter away duplicate fnames client-side during the migration process.