Open
Conversation
mfangaritav
requested changes
Aug 25, 2024
Collaborator
mfangaritav
left a comment
mfangaritav
left a comment
There was a problem hiding this comment.
I tried the notebook and I ran a non-linear squares inversion but it seems like the synthetic data is not being loaded into the insarobs object, so maybe the version that is in this PR was not the one that was used in the mcmc inversion?
Collaborator
|
Also, I added some of the changes that you suggested to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
transform_order_natural2regdisandtransform_order_regdis2naturalfunctions that allow direct forward modelling in regdis class without the need of initializing okada models for patches.Added a checkerboard test to show model capability.