[Custom Build Steps] Fixes to get custom build steps working. - #101
Closed
kudaba wants to merge 1 commit into
Closed
[Custom Build Steps] Fixes to get custom build steps working.#101kudaba wants to merge 1 commit into
kudaba wants to merge 1 commit into
Conversation
kudaba
commented
Oct 20, 2020
kudaba
commented
Contributor
- Add quotes to executable to support spaces in paths since the quotes can't be added by the user.
- Standardize the path when looking up the build step since it may be lower cased.
* Add quotes to executable to support spaces in paths since the quotes can't be added by the user. * Standardize the path when looking up the build step since it may be lower cased.
kudaba
force-pushed
the
custom_build_step_fix
branch
from
October 20, 2020 06:48
818ba7a to
dcc9e69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.