Merge from official#2
Merged
Merged
Conversation
* Removes forced unwrapping on core. Adjusted FRSpiner and FRMetadata * Renamed ErrorKind enum options * Adjusted the project to conform with changes * Removed forced unwrapping from FRMetadata and adjusting the project to conform with changes
Setting the scroll direction to horizontal on the config was ignored because the current scroll direction returned 0 instead of nil on the first run, so it never reaches the guard's else block.
* Fix code style * Add custom unzip path setting to FolioReaderContainer
- Removed code that sets reader audio session to active immediately after pod init
- Added audio session interruption observer to update player/player menu state
- Closes #321
* Made a new screen for taking notes and modified some other codes * removed unnecessary chagnes * commit missing file
…fter select any color in menu. (#339) https://github.com/FolioReader/FolioReaderKit/issues/316
…arch for toc reference. (#342) * Fixed FolioReaderWebView, menu controller still showing colors menu after select any color in menu. https://github.com/FolioReader/FolioReaderKit/issues/316 * Fixed get chapter name method, applied recursive search for toc reference. * Fix iOS 11 auto adjust inset bug and closes #332 #312 #261 (reverted from commit 0f161dd) * Fixed FolioReaderWebView, menu controller still showing colors menu after select any color in menu. https://github.com/FolioReader/FolioReaderKit/issues/316 (reverted from commit b8cccd7) * Fixed get chapter name method, applied recursive search for toc reference. (reverted from commit 4577d99) * Fixed get chapter name method, applied recursive search for toc reference. (reverted from commit 4577d99) (reverted from commit f4e657c) * Fix iOS 11 auto adjust inset bug and closes #332 #312 #261 (unreverted from commit 525b9b5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.