add preview flag for sf api to support multiple hasEmail #1000#1002
Draft
add preview flag for sf api to support multiple hasEmail #1000#1002
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds preview flag support to the SiteFarm API to handle multiple hasEmail addresses for experts, addressing issue #1000. The implementation allows for backward compatibility by maintaining the existing API behavior while providing enhanced email support through a preview parameter.
- Extracts utility functions from the main API file to a dedicated utils.js module for better organization
- Implements preview format middleware that supports multiple email addresses for experts
- Updates OpenAPI documentation with both standard and preview schemas
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| services/base-service/models/sitefarm/utils.js | New utility module containing extracted SiteFarm formatting functions and preview middleware |
| services/base-service/models/sitefarm/swagger.json | Updated OpenAPI schema with cleaner structure and version bump |
| services/base-service/models/sitefarm/swagger-preview.json | New preview schema documenting multiple email support |
| services/base-service/models/sitefarm/api.js | Refactored to use extracted utilities and added preview parameter routing logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mgrow1
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.