This repository was archived by the owner on Nov 14, 2020. It is now read-only.
Full Code Review for Open Source Approval #11
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # Javascript Node CircleCI 2.0 configuration file | ||
| # | ||
| # Check https://circleci.com/docs/2.0/language-javascript/ for more details | ||
| # | ||
| version: 2 | ||
| jobs: | ||
| build: | ||
| docker: | ||
| - image: circleci/node:8.11 | ||
|
|
||
| working_directory: ~/fluent-react-utils | ||
|
|
||
| steps: | ||
| - checkout | ||
|
|
||
| - run: sudo npm install -g lerna | ||
| - run: lerna bootstrap |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| * @hkasemir |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,13 @@ | ||
| Copyright 2018 Udacity | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,37 +1,19 @@ | ||
| # fluent-react-utils | ||
| String extraction and helper components for using [fluent-react](https://github.com/projectfluent/fluent.js/tree/master/fluent-react) in your projects. | ||
|
|
||
|
|
||
| This is a mono-repo containing two packages: | ||
| ## [fluent-react-components](./packages/components) | ||
| Helper components to write cleaner jsx with fluent-react. | ||
|
|
||
| ## [fluent-react-extract](./packages/extraction) | ||
| CLI for extracting strings for localization into ftl files. | ||
|
|
||
|
|
||
| # Contributing | ||
|
|
||
| To get started developing locally, install dependencies and build the packages using | ||
|
|
||
| ``` | ||
| $ lerna bootstrap | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "packages": [ | ||
| "packages/*" | ||
| ], | ||
| "version": "0.1.2" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
|
There was a problem hiding this comment. Do we need to have separate |
||
| "env": { | ||
| "development": { | ||
| "presets": ["env", "react", "es2015"], | ||
|
There was a problem hiding this comment. shouldn't need |
||
| "plugins": [ | ||
| "add-module-exports", | ||
| "transform-object-rest-spread" | ||
| ] | ||
| }, | ||
| "production": { | ||
| "presets": ["env", "react", "es2015", "minify"], | ||
| "plugins": [ | ||
| "add-module-exports", | ||
| "transform-object-rest-spread" | ||
| ] | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "parser": "babel-eslint", | ||
| "extends": "airbnb", | ||
| "env": { | ||
| "mocha": true | ||
| }, | ||
| "rules": { | ||
| "comma-dangle": ["error", "only-multiline"], | ||
| "consistent-return": "off", | ||
| "import/prefer-default-export": "off", | ||
| "import/no-extraneous-dependencies": "off", | ||
| "import/no-unresolved": "off", | ||
| "import/extensions": "off", | ||
| "jsx-a11y/alt-text": "off", | ||
| "jsx-a11y/anchor-has-content": "off", | ||
| "jsx-a11y/anchor-is-valid": "off", | ||
| "jsx-a11y/heading-has-content": "off", | ||
| "no-console": "off", | ||
| "react/jsx-filename-extension": "off" | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this what we want all our work licensed under? I'm kinda curious why not MIT - though they're both very permissive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ultimately we decided to use this because it is what the base fluent package is licensed under, and so it made sense to use the same one since they will be used together.