TEMPO code cleanup and refactor for v3.0.0 and MPAS release by AndersJensen-NOAA · Pull Request #192 · ufs-community/MPAS-Model

AndersJensen-NOAA · 2025-12-01T23:53:58Z

removed unused configuration variable
added graupel volume to init_atmosphere registry (scalars are inconsistent between init_atmosphere and atmosphere #167)
formatted code

The title above should be a 1 line short summary of the pull request (i.e. what the project the PR represents is intended to do).

Enter a description of this PR. This should include why this PR was created, and what it does.

Testing and relations to other Pull Requests should be added as subsequent comments.

See the below examples for more information.
MPAS-Dev/MPAS#930
MPAS-Dev/MPAS#931

Priority Reviewers

Please list the developers/collaborators you'd like to prioritize for review
Example:
- @clark-evans

- added graupel volume to init_atmosphere registry - formatted code

…mpas

guoqing-noaa · 2026-01-14T18:17:39Z

Any updates on the timeline of this PR? Thanks!

clark-evans · 2026-01-14T18:27:54Z

Any updates on the timeline of this PR? Thanks!

It's currently being tested in dev1. The output so far looks fairly reasonable. If that holds with formal verification, I expect we'll be ready to merge next week or shortly thereafter.

guoqing-noaa · 2026-01-14T18:29:54Z

Any updates on the timeline of this PR? Thanks!

It's currently being tested in dev1. The output so far looks fairly reasonable. If that holds with formal verification, I expect we'll be ready to merge next week or shortly thereafter.

That's great! Thanks for the good news!

…mentation

joeolson42

I suppose... ;-)

…_formatting

AndersJensen-NOAA · 2026-02-12T20:49:14Z

@dustinswales @clark-evans Three tests are failing. I though it was an issue with the lookup tables, so I made a few commits to try and modify, but it could be a namelist issue also with the update to tempo v3. Suggestions for easy ways to debug would be helpful.

clark-evans · 2026-02-12T21:07:51Z

@dustinswales @clark-evans Three tests are failing. I though it was an issue with the lookup tables, so I made a few commits to try and modify, but it could be a namelist issue also with the update to tempo v3. Suggestions for easy ways to debug would be helpful.

@dustinswales are we still pulling the namelists from barlage/mpas_testcase? That's what it looks like to me in the workflow. I'm guessing the feature tests are failing because Anders moved the TEMPO namelist parameters to a new namelist block that isn't represented in the testcase namelists.

If this is the case, then the tests would fail until that repo is updated - but we don't necessarily want to update that repo until after this PR is merged. Is there a hacky way of getting around this to test the updated code?

dustinswales · 2026-02-12T21:41:49Z

@clark-evans You are correct about the nml.
@AndersJensen-NOAA just stopped by and we chatted. The plan is for Anders to update his fork of the MPAS case configuration repo, and make any necessary changes for the TEMPO namelist updates.
Also, we should update the CI scripts to use Anders repo rather than updating the one owned by @barlage (We should've handed this off to someone at GSL when Mike left, so it's a good time for Anders to adopt it :))

AndersJensen-NOAA · 2026-02-12T22:21:40Z

@clark-evans You are correct about the nml. @AndersJensen-NOAA just stopped by and we chatted. The plan is for Anders to update his fork of the MPAS case configuration repo, and make any necessary changes for the TEMPO namelist updates. Also, we should update the CI scripts to use Anders repo rather than updating the one owned by @barlage (We should've handed this off to someone at GSL when Mike left, so it's a good time for Anders to adopt it :))

Thanks -- I may have to iterate a bit but I think I can get this working with running the base with old tables and old namelists and the feature with new tables and new namelists. It may take a few tries. If I get stuck I'll reach out again.

AndersJensen-NOAA · 2026-02-13T16:48:59Z

@dustinswales -- I have things working. Can you take a quick peek at my changes to run_mpas.yaml and run_mpas_hrrr.yaml to make sure that things look good?

@clark-evans ready to merge once Dustin and you okays this.

clark-evans · 2026-02-13T16:56:43Z

The comparison script output from the GSL hrrrv5 tests includes the following line for all three tests:

"DIFFER : Failed to find variable ng in file "/home/runner/work/run_bl/history.2024-02-02_18.00.00.nc"."

This also appears for all subsequent forecast hours. Since it's in the run_bl directory, I'm guessing Ng is not in the baseline output but is in the feature output. Is that to be expected, @AndersJensen-NOAA?

dustinswales · 2026-02-13T17:16:04Z

@AndersJensen-NOAA Looks good to me.

I will say that sleuthing through the CI logs to see that this is answer changing is a big pain.
We could add a plotting step to the CI script that plots any differences and stores them as an artifacts.
(This we the diffs would be right in your face in the PR, and we could double-check the developers "blessing of the changes")

AndersJensen-NOAA · 2026-02-13T17:18:19Z

The comparison script output from the GSL hrrrv5 tests includes the following line for all three tests:

"DIFFER : Failed to find variable ng in file "/home/runner/work/run_bl/history.2024-02-02_18.00.00.nc"."

This also appears for all subsequent forecast hours. Since it's in the run_bl directory, I'm guessing Ng is not in the baseline output but is in the feature output. Is that to be expected, @AndersJensen-NOAA?

great catch @clark-evans -- I reverted the changes to the namelist for the baseline run only, in an attempt to not change the baselines as I had inadvertently turned off the hail aware option when updating namelists.

New tests are running now

…ng snow/graupel

clark-evans · 2026-02-19T15:23:50Z

Final commit looks good to me; I can merge once @dustinswales gives the OK.

guoqing-noaa · 2026-02-26T20:11:56Z

Hooray, thanks for the merge of this PR!

With this PR, rrfs-workflow can now use the official gsl/develop branch!

@AndersJensen-NOAA, to confirm, we will need the name list change and the three new fix files you shared with me when establishing the AR3.5km PEAR runs, right? Thanks!

AndersJensen-NOAA · 2026-02-27T22:28:00Z

Hooray, thanks for the merge of this PR!

With this PR, rrfs-workflow can now use the official gsl/develop branch!

@AndersJensen-NOAA, to confirm, we will need the name list change and the three new fix files you shared with me when establishing the AR3.5km PEAR runs, right? Thanks!

Yes, the changes that I shared with you are applicable here too!

…ase (ufs-community#192) * removed unused configuration variable - added graupel volume to init_atmosphere registry - formatted code * cleaned up core_atmosphere registry for tempo * cleaned up mpas tempo driver call and removed tempo table build from mpas * v3.0.0 updates consistent with tempo refactor * v3.0.0 tempo refactor with ml prediction for bl clouds * update point to tempo v3 and clean up code to better match NCAR implementation * Update CMakeList for tempo v3 * add compile option for tempo * More updates to github runners for tempo v3 * change workflow to pull tempo v2 and v3 tables * adds flag to turn on/off ability to calculate reflectivity from melting snow/graupel * update pointer to tempo v3.0.2 * update to version 3.0.3 with more ccpp changes * Update version number in README --------- Co-authored-by: Clark Evans <clark.evans@noaa.gov>

* v8.3.1-2.13: Update MPAS HRRR CI test for tempo v3 lookup tables (ufs-community#213) * Update MPAS HRRR CI test for tempo v3 lookup tables * Update version in README * v8.3.1-2.14: TEMPO code cleanup and refactor for v3.0.0 and MPAS release (ufs-community#192) * removed unused configuration variable - added graupel volume to init_atmosphere registry - formatted code * cleaned up core_atmosphere registry for tempo * cleaned up mpas tempo driver call and removed tempo table build from mpas * v3.0.0 updates consistent with tempo refactor * v3.0.0 tempo refactor with ml prediction for bl clouds * update point to tempo v3 and clean up code to better match NCAR implementation * Update CMakeList for tempo v3 * add compile option for tempo * More updates to github runners for tempo v3 * change workflow to pull tempo v2 and v3 tables * adds flag to turn on/off ability to calculate reflectivity from melting snow/graupel * update pointer to tempo v3.0.2 * update to version 3.0.3 with more ccpp changes * Update version number in README --------- Co-authored-by: Clark Evans <clark.evans@noaa.gov> * update to joes mynn * Updating version number * v8.3.1-2.16: Adding MYNN-SFC submodule to MPAS (ufs-community#210) * submodularizing the MYNN surface layer scheme * bug fix in physics/Makefile * modified sfclayer and seaice driver for mynnsfc submodule * removing compilation of (my) old MYNN sfclayer scheme * added note in mpas_atmphys_vars.F that qcg is no longer needed in mynnsfc submodule * added config options for MYNN sfc layer submodule * bug fix for bringing in new flags for MYNN sfclayer submodule * Final bug fixes for MPAS compilation * Updating pointer to MYNN-SFC with a new debug Makefile for MPAS * bug fix for adding necessary input into the MYNN-SFC submodule * addressing cmake errors * Final update to MYNN-SFC pointer, which includes RUC-tuned option config_mynn_sfcflux_land =1 * changing default config_mynn_sfcflux_land from 0 to 1 * a few bug fixes in MYNN-SFC and corresponding driver changes * update pointer to MYNN-SFC, only formatting/cleanup * Update version number * fix typo --------- Co-authored-by: Clark Evans <clark.evans@noaa.gov> * v8.3.1-2.17: Restructure GFL submodule for MPAS, WRF, and CCPP (ufs-community#211) * "Resture GFL submodule for MPAS, WRF, and CCPP" * "update GFL for CMake" * "turn off shallow convection for both bl_mynn and bl_mynnedmf" * Update version number * v8.3.1-2.18: hotfix to the build failure using `make -j8` with spack-stack (ufs-community#221) * core_mynnsfc and core_physics_noahmp need to depend on core_physics_init * bump version to 8.3.1-2.18 * Update PR template Added mandatory questions section to PR template. * Containerized CI + Cleanup testing (ufs-community#218) * Update CI * Update README.md --------- Co-authored-by: dustinswales <dswales@ucar.edu> * v8.3.1-2.20: Add mmm physics as submobule. (ufs-community#233) * Initial commit * CI trigger test * Address reviewer comment * Update README.md * v8.3.1-2.21: Add two new namelist options to control the hydrometeors to be included in the LBC files. (ufs-community#234) * Add two new namelist options and packages to control the hydrometeors to be included in the LBC files. This is because the resource model has different hydrometeors in their products. The two options added are for the LBC from GFS or GEFS. * Updating tabs to spaces for selected registry elements * In core_init_atmosphere/Registry.xml, change bdy option name from 'tempoall' to 'rrfs' for consistency with 'gfs' * Update version number --------- Co-authored-by: Clark Evans <clark.evans@noaa.gov> * v8.3.1-2.22: restore extra spaces in mpas_stream_manager.F to match NCAR's version (ufs-community#238) * restore extra spaces in mpas_stream_manager.F to match NCAR's version * Update version number --------- Co-authored-by: Clark Evans <clark.evans@noaa.gov> * final updates to match --------- Co-authored-by: AndersJensen-NOAA <132939212+AndersJensen-NOAA@users.noreply.github.com> Co-authored-by: Clark Evans <clark.evans@noaa.gov> Co-authored-by: Joseph Olson <joeolson42@users.noreply.github.com> Co-authored-by: haiqinli <38666296+haiqinli@users.noreply.github.com> Co-authored-by: Guoqing Ge <guoqing.ge@noaa.gov> Co-authored-by: Dustin Swales <dustin.swales@noaa.gov> Co-authored-by: dustinswales <dswales@ucar.edu> Co-authored-by: Ming Hu <Ming.Hu@noaa.gov>

- removed unused configuration variable

c61d9f1

- added graupel volume to init_atmosphere registry - formatted code

AndersJensen-NOAA mentioned this pull request Dec 1, 2025

scalars are inconsistent between init_atmosphere and atmosphere #167

Closed

- cleaned up core_atmosphere registry for tempo

4e732be

clark-evans mentioned this pull request Dec 2, 2025

Occasional Github Actions failures when calling wget #186

Closed

clark-evans linked an issue Dec 2, 2025 that may be closed by this pull request

scalars are inconsistent between init_atmosphere and atmosphere #167

Closed

AndersJensen-NOAA added 7 commits December 13, 2025 22:55

cleaned up mpas tempo driver call and removed tempo table build from …

b1f0da2

…mpas

v3.0.0 updates consistent with tempo refactor

4f47418

update pointer to tempo refactor

7306023

v3.0.0 tempo refactor with ml prediction for bl clouds

50294c1

update tempo pointer

abd6351

update tempo pointer

563d91e

Merge branch 'gsl/develop' into tempo_v3.0.0_formatting

39e1932

This was referenced Jan 14, 2026

TEMPO 1-moment (true) hail option #109

Closed

Intel make/cmake tests failing #205

Closed

AndersJensen-NOAA added 2 commits February 5, 2026 14:57

Merge branch 'gsl/develop' into tempo_v3.0.0_formatting

4eec574

update point to tempo v3 and clean up code to better match NCAR imple…

df1e4d4

…mentation

AndersJensen-NOAA marked this pull request as ready for review February 5, 2026 19:08

AndersJensen-NOAA requested review from clark-evans and dustinswales as code owners February 5, 2026 19:08

clark-evans requested a review from joeolson42 February 5, 2026 21:02

joeolson42 approved these changes Feb 6, 2026

View reviewed changes

AndersJensen-NOAA added 6 commits February 11, 2026 23:38

Merge remote-tracking branch 'upstream/gsl/develop' into tempo_v3.0.0…

31057e4

…_formatting

Update CMakeList for tempo v3

0aa138b

fix the typo in CMakeList

93f087f

add compile option for tempo

2f6b931

More updates to github runners for tempo v3

8f2f0b0

this might fix failing regression tests

5663e40

update pointer to new test data fork

5a5d15e

AndersJensen-NOAA added 3 commits February 12, 2026 23:27

change workflow to pull tempo v2 and v3 tables

76f84ba

change RT to debug

1da6374

revert debug testing in CI and update tempo pointer

f9760f9

dustinswales added the answer changing label Feb 13, 2026

revert baseline runtime configs to original repo

0b29d03

dustinswales requested review from dustinswales and removed request for dustinswales February 13, 2026 17:16

clark-evans approved these changes Feb 13, 2026

View reviewed changes

AndersJensen-NOAA added 2 commits February 19, 2026 03:33

adds flag to turn on/off ability to calculate reflectivity from melti…

727a9c8

…ng snow/graupel

update pointer to tempo v3.0.2

c801f83

update to version 3.0.3 with more ccpp changes

7ea1c4a

clark-evans mentioned this pull request Feb 24, 2026

Correct range of volg vules? #174

Closed

clark-evans linked an issue Feb 24, 2026 that may be closed by this pull request

Correct range of volg vules? #174

Closed

Update version number in README

63b6469

clark-evans merged commit f506b43 into ufs-community:gsl/develop Feb 26, 2026
18 checks passed

Conversation

AndersJensen-NOAA commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Priority Reviewers

Uh oh!

guoqing-noaa commented Jan 14, 2026

Uh oh!

clark-evans commented Jan 14, 2026

Uh oh!

guoqing-noaa commented Jan 14, 2026

Uh oh!

joeolson42 left a comment

Choose a reason for hiding this comment

Uh oh!

AndersJensen-NOAA commented Feb 12, 2026

Uh oh!

clark-evans commented Feb 12, 2026

Uh oh!

dustinswales commented Feb 12, 2026

Uh oh!

AndersJensen-NOAA commented Feb 12, 2026

Uh oh!

AndersJensen-NOAA commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clark-evans commented Feb 13, 2026

Uh oh!

dustinswales commented Feb 13, 2026

Uh oh!

AndersJensen-NOAA commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clark-evans commented Feb 19, 2026

Uh oh!

Uh oh!

guoqing-noaa commented Feb 26, 2026

Uh oh!

AndersJensen-NOAA commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AndersJensen-NOAA commented Dec 1, 2025 •

edited

Loading

AndersJensen-NOAA commented Feb 13, 2026 •

edited

Loading

AndersJensen-NOAA commented Feb 13, 2026 •

edited

Loading