Skip to content

Remove stale global coupled RTs (first pass)#3142

Merged
gspetro-NOAA merged 25 commits intoufs-community:developfrom
DeniseWorthen:feature/remove_stalecpldRTs
Mar 18, 2026
Merged

Remove stale global coupled RTs (first pass)#3142
gspetro-NOAA merged 25 commits intoufs-community:developfrom
DeniseWorthen:feature/remove_stalecpldRTs

Conversation

@DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Mar 12, 2026

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers. NA
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Fill out all sections of this template.

Description:

This PR makes a first pass at updating the global coupled RTs by removing tests, updating the compilation and adding tests where needed. The changes

  • remove the aerosol component when not needed
  • remove "pdlib p8" tests, which are now covered by the gfsv17 tests. The removed tests use waves in the fast coupling loop. A wave-ice coupling RT will be added in the future which will exercise wave coupling in the fast loop.
  • add tests for SFS with IntelLLVM and GNU for both v17 and SFS
  • turns off tests atm_ds2s_docn_dice which depends on the deleted nowave_noaero test. These can be re-enabled in the next pass of the cleanup once it is clear which tests will remain.
  • creates standalone QR control and restart tests and removes coupled version

Most of the existing cpld p8 suite of tests (C96, 1deg OCN/ICE/WAV on tripole grid, fast loop coupling) are left in place for now; they will be either updated or removed in the next pass of cleanup.

The temporary file rt.cleanup was used to generate baselines on Ursa and C6. All tests in rt.cleanup passed the staged baselines. This file and the removed test themselves (renamed w/ prepended x in the tests/tests directory will be removed.

Commit Message:

* UFSWM - remove stale global coupled RTs and add additional RTs for SFS and v17

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • None

Documentation:

  • Documentation update required.
    • Relevant updates are included with this PR.
    • A WM issue has been opened to track the need for a documentation update; a person responsible for submitting the update has been assigned to the issue (link issue).
  • Documentation update NOT required.
    • Explanation:

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.

A first pass of running the full RTs produces one explicit failure for an existing test. The cpld_control_p8_lnd test fails because the tracers are now missing from the atmf history file and tracer restart files.

The following tests fail due to missing baselines (they are new tests):

cpld_debug_sfs_intelllvm
cpld_control_gfsv17_gnu
cpld_debug_gfsv17_gnu
cpld_control_sfs_gnu
cpld_debug_sfs_gnu

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@DeniseWorthen DeniseWorthen marked this pull request as ready for review March 13, 2026 18:46
@gspetro-NOAA gspetro-NOAA added Baseline Updates Current baselines will be updated. New Baselines New baselines will be added to project. labels Mar 13, 2026
@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Pre-testing required in PRs to Process Mar 13, 2026
@gspetro-NOAA gspetro-NOAA moved this from Pre-testing required to Review in PRs to Process Mar 16, 2026
@gspetro-NOAA gspetro-NOAA moved this from Review to Schedule in PRs to Process Mar 16, 2026
@gspetro-NOAA gspetro-NOAA added the On Deck This is the next PR in line for testing/merge. label Mar 16, 2026
@gspetro-NOAA
Copy link
Collaborator

@DeniseWorthen Please sync w/develop as soon as you can; we'd like to process your PR next.

@gspetro-NOAA gspetro-NOAA added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. and removed On Deck This is the next PR in line for testing/merge. labels Mar 17, 2026
@gspetro-NOAA gspetro-NOAA added the In Testing The PR that is currently in testing stages label Mar 17, 2026
Copy link
Collaborator

@gspetro-NOAA gspetro-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the warnings/remarks check locally with the bugfix from my PR #3149 , and everything passes, so the failing check on this PR can be ignored!

@gspetro-NOAA gspetro-NOAA removed the In Testing The PR that is currently in testing stages label Mar 18, 2026
@gspetro-NOAA gspetro-NOAA merged commit ae75633 into ufs-community:develop Mar 18, 2026
12 of 14 checks passed
@github-project-automation github-project-automation bot moved this from Schedule to Done in PRs to Process Mar 18, 2026
@DeniseWorthen DeniseWorthen self-assigned this Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated. New Baselines New baselines will be added to project. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.

Projects

Archived in project

5 participants