Remove stale global coupled RTs (first pass)#3142
Merged
gspetro-NOAA merged 25 commits intoufs-community:developfrom Mar 18, 2026
Merged
Remove stale global coupled RTs (first pass)#3142gspetro-NOAA merged 25 commits intoufs-community:developfrom
gspetro-NOAA merged 25 commits intoufs-community:developfrom
Conversation
Collaborator
|
@DeniseWorthen Please sync w/develop as soon as you can; we'd like to process your PR next. |
This was referenced Mar 17, 2026
DeniseWorthen
commented
Mar 18, 2026
FernandoAndrade-NOAA
approved these changes
Mar 18, 2026
gspetro-NOAA
approved these changes
Mar 18, 2026
Collaborator
gspetro-NOAA
left a comment
There was a problem hiding this comment.
I ran the warnings/remarks check locally with the bugfix from my PR #3149 , and everything passes, so the failing check on this PR can be ignored!
NickSzapiro-NOAA
approved these changes
Mar 18, 2026
Merged
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Queue Requirements:
test_changes.listindicates which tests, if any, are changed by this PR. Committest_changes.list, even if it is empty.Description:
This PR makes a first pass at updating the global coupled RTs by removing tests, updating the compilation and adding tests where needed. The changes
atm_ds2s_docn_dicewhich depends on the deleted nowave_noaero test. These can be re-enabled in the next pass of the cleanup once it is clear which tests will remain.Most of the existing
cpld p8suite of tests (C96, 1deg OCN/ICE/WAV on tripole grid, fast loop coupling) are left in place for now; they will be either updated or removed in the next pass of cleanup.The temporary file
rt.cleanupwas used to generate baselines on Ursa and C6. All tests inrt.cleanuppassed the staged baselines. This file and the removed test themselves (renamed w/ prependedxin the tests/tests directory will be removed.Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Documentation:
Changes
Regression Test Changes (Please commit test_changes.list):
A first pass of running the full RTs produces one explicit failure for an existing test. The
cpld_control_p8_lndtest fails because the tracers are now missing from theatmfhistory file and tracer restart files.The following tests fail due to missing baselines (they are new tests):
Input data Changes:
Library Changes/Upgrades:
Testing Log: