Add Typescript types definition for all hooks#206
Add Typescript types definition for all hooks#206tylermcginnis merged 1 commit intouidotdev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Please! You're our hero :) |
joaopcm
left a comment
joaopcm
left a comment
There was a problem hiding this comment.
Congrats! This is not only a PR, it's an art! ⭐
“I once saw him kill three men in a bar... With a pencil.”
|
would love to see this in a release soon!! <3 |
|
wen release |
|
Nice job! But I have a proposal, why not rewrite the hooks with TypeScript? I believe this could bring a better DX, I'm open to work on it if this is wanted |
I feel like this is more work than it's worth right now, this solution is a stop-gap solution in the meanwhile and it should be merged. |
I agree, this should be merged first in the meantime. |
|
Or consider using https://usehooks-ts.com/. |
It seems to be a good alternative with TS indeed |
I 100% agree this would be the ideal approach but I wanted something quick to start with just as @ariesclark highlighted as well. I can take some time over the weekend to re-write the hooks with Typescript. |
|
wen merge ser? |
|
Sorry for the delay everyone. Merged. Thank you @toystars! |
9 participants
Thanks for the awesome library. Saves lots of time from writing these hooks from scratch. I was a little bit disappointed there weren't Typescript type definitions and had to add declarations for the few hooks I am currently using. So I added types for all the hooks in the library (excluding the experimental hooks).